On Fri, May 18, 2018 at 10:28:04AM -0600, Keith Busch wrote: > On Thu, May 17, 2018 at 04:23:45PM +0200, Johannes Thumshirn wrote: > > > Agreed. Alternatively possibly call the driver's reset_preparei/done > > > callbacks. > > > > Exactly, but as long as we can issue the reset via sysfs the test-case > > is still valid. > > I disagree the test case is valid. The test writes '0' to the > pci-sysfs 'enable', but the driver also disables the pci device as part > of resetting, which is a perfectly reasonable thing for a driver to do. > > If the timing of the test's loop happens to write '0' right after the > driver disabled the device that it owns, a 'write error' on that sysfs > write occurs, and blktests then incorrectly claims the test failed. Hmm, ok that's a valid point. But seeing you have sent a patch for blktests anyways I think it's gone now. -- Johannes Thumshirn Storage jthumshirn@xxxxxxx +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
