On Fri, May 18, 2018 at 4:42 PM, Bjorn Helgaas <helgaas@xxxxxxxxxx> wrote: > Hi Rob, > > On Thu, Apr 05, 2018 at 02:31:54PM -0500, Rob Herring wrote: >> Add COMPILE_TEST on driver config options with it. Some ARM drivers >> still have arch dependencies, so we have to keep those dependent on ARM. >> >> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@xxxxxxx> >> Cc: Bjorn Helgaas <bhelgaas@xxxxxxxxxx> >> Cc: linux-pci@xxxxxxxxxxxxxxx >> Signed-off-by: Rob Herring <robh@xxxxxxxxxx> > >> config PCIE_ALTERA >> bool "Altera PCIe controller" >> - depends on ARM || NIOS2 >> - depends on OF_PCI >> + depends on ARM || NIOS2 || COMPILE_TEST > > Did you intend to drop the OF_PCI dependency? No, that should have been removed when OF_PCI was in commit 4670d610d592 ("PCI: Move OF-related PCI functions into PCI core"). > I see that CONFIG_OF_PCI doesn't exist, so that looks bogus. > > But drivers/pci/host/pcie-altera.c still uses > devm_of_pci_get_host_bridge_resources(), so I think this should probably > still depend on CONFIG_OF? There's an empty version so it shouldn't matter. Rob