On Fri, May 11, 2018 at 07:53:21AM +0200, Jan Kiszka wrote: > On 2018-05-11 07:45, Jan Kiszka wrote: > > On 2018-05-11 07:08, Julia Lawall wrote: > >> The devm_kzalloc on line 324 makes the kfrees on lines 332 and 355 > >> incorrect. They can just be removed. > > > > True. In fact, 358 and 359 should go as well - making them obsolete is > > the whole point of this conversion. > > More precisely, 332 needs to become devm_kfree because we skip over one > resource without failing. > > > > > The issue comes already with patch "Add dev parameter to > > __of_pci_get_host_bridge_resources()" when dev != NULL. Bjorn, should I > > resend the series with that patch fixed and the rest rebased? Or do you > > prefer when I update only this patch, fixing the issue here? > > ...or is a fixup patch on top preferred? Sorry, I missed this until now. If you send me a fixup patch on top of my pci/resource branch, I'll just fold it in.
