On Thu, 2018-05-10 at 11:33 -0500, Bjorn Helgaas wrote: > On Thu, May 03, 2018 at 03:00:43PM -0500, Bjorn Helgaas wrote: > > From: Bjorn Helgaas <bhelgaas@xxxxxxxxxx> > > > > In some cases pcie_get_minimum_link() returned misleading > > information > > because it found the slowest link and the narrowest link without > > considering the total bandwidth of the link. > > > > For example, consider a path with these two links: > > > > - 16.0 GT/s x1 link (16.0 * 10^9 * 128 / 130) * 1 / 8 = 1969 > > MB/s > > - 2.5 GT/s x16 link ( 2.5 * 10^9 * 8 / 10) * 16 / 8 = 4000 > > MB/s > > > > The available bandwidth of the path is limited by the 16 GT/s link > > to about > > 1969 MB/s, but pcie_get_minimum_link() returned 2.5 GT/s x1, which > > corresponds to only 250 MB/s. > > > > Callers should use pcie_print_link_status() instead, or > > pcie_bandwidth_available() if they need more detailed information. > > > > Remove pcie_get_minimum_link() since there are no callers left. > > > > Signed-off-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx> > > Hi Jeff, > > I got your note that you applied this to dev-queue. I assume that > means you also applied the preceding patches that removed all the > users. I got a note about ixgbe, but not the others, so I'm just > double-checking. I did initially apply it, but realized that I would have to apply the earlier patches as well, which did not pertain to the Intel wired LAN drivers. So I have removed this patch from queue and will only be testing the ixgbe patch of the series, which Andrew has already tested and responded to.
Attachment:
signature.asc
Description: This is a digitally signed message part
