On Fri, Apr 27, 2018 at 02:22:07PM -0500, Bjorn Helgaas wrote: > Sinan mooted the idea of using a "no-wait" path of sending the "don't > generate hotplug interrupts" command. I think we should work on this > idea a little more. If we're shutting down the whole system, I can't > believe there's much value in *anything* we do in the pciehp_remove() > path. > > Maybe we should just get rid of pciehp_remove() (and probably > pcie_port_remove_service() and the other service driver remove methods) > completely. That dates from when the service drivers could be modules that > could be potentially unloaded, but unloading them hasn't been possible for > years. Every Thunderbolt device contains a PCIe switch with at least one (downstream) hotplug port, so pciehp_remove() is executed on unplug of a Thunderbolt device and the assumption that it's unnecessary simply because it's builtin isn't correct. Thanks, Lukas
