On Thu, May 03, 2018 at 06:01:08PM -0500, Bjorn Helgaas wrote: > If you think we can remove pciehp_force, that would be awesome. This > should be a separate patch all by itself, of course, and include your > reasoning above. > > I would also love to revert db63d40017a5 ("PCI: pciehp: Do not clear > Presence Detect Changed during initialization") because I'm not > convinced that trying to handle interrupts that happened before > binding the driver makes sense. It *would* make sense to me to enable > interrupts, clear the "changed" status bits so future changes will > cause interrupts, and check the "state" status bits and act on them. OK, I'll make that a separate patch series completely. Regarding the current patch set, do you have any additional comments / converns? I would like to send out v6 next week.