On Mon, Apr 30, 2018 at 05:27:32PM -0400, Sinan Kaya wrote: > On 4/30/2018 5:17 PM, Bjorn Helgaas wrote: > How about remove() only if MSI is disabled? Most root port interrupts > are MSI based anyhow. I think the code is perfectly fine as it is and doesn't need to nor should be modified. We should just add a quirk for this particular chipset that it doesn't support Command Completed interrupts (if that's what's broken). In the case of Thunderbolt controllers, the first few had the NoCompl bit set incorrectly in config space and Intel hardware engineers confirmed the error. These or similar oddities may occur with more chipsets, so I propose moving existing quirks to a separate file, thereby avoiding that they clutter generic code. The blinkenlights feature added with commit 576243b3f9ea is a similar quirk that could be moved to a separate pciehp_quirks.c file. Thanks, Lukas
