Acked-by: Xiaowei Song <songxiaowei@xxxxxxxxxxxxx> -----邮件原件----- 发件人: Lorenzo Pieralisi [mailto:lorenzo.pieralisi@xxxxxxx] 发送时间: 2018年4月16日 21:49 收件人: songxiaowei <songxiaowei@xxxxxxxxxxxxx> 抄送: Loic Poulain <loic.poulain@xxxxxxxxxx>; Wangbinghui <wangbinghui@xxxxxxxxxxxxx>; linux-pci@xxxxxxxxxxxxxxx; Bjorn Helgaas <bhelgaas@xxxxxxxxxx>; Guodong Xu <guodong.xu@xxxxxxxxxx> 主题: Re: 答复: [PATCH] PCI: kirin: Fix reset gpio name On Mon, Apr 16, 2018 at 11:48:52AM +0000, songxiaowei wrote: > It's a bug indeed, thank you very much for the patch. I think the > patch is ok. Is this an ACK ? Please provide one if you want me to merge this fix. Lorenzo > -----邮件原件----- > 发件人: Loic Poulain [mailto:loic.poulain@xxxxxxxxxx] > 发送时间: 2018年4月16日 19:35 > 收件人: songxiaowei <songxiaowei@xxxxxxxxxxxxx>; Wangbinghui > <wangbinghui@xxxxxxxxxxxxx> > 抄送: linux-pci@xxxxxxxxxxxxxxx; Bjorn Helgaas <bhelgaas@xxxxxxxxxx>; > lorenzo.pieralisi@xxxxxxx; Loic Poulain <loic.poulain@xxxxxxxxxx>; > Guodong Xu <guodong.xu@xxxxxxxxxx> > 主题: Re: [PATCH] PCI: kirin: Fix reset gpio name > > Hi Xiaowei, > > On 3 April 2018 at 11:19, Loic Poulain <loic.poulain@xxxxxxxxxx> wrote: > > As documented in the device-tree bindings (pci/kirin-pcie.txt) and > > defined in existing device-tree (hi3660.dtsi), the reset gpio name > > is 'reset-gpios'. However, driver looks for a 'reset-gpio' resource > > which makes the driver probe fail. Fix this. > > > > Fixes: fc5165db245a ("PCI: kirin: Add HiSilicon Kirin SoC PCIe > > controller driver") > > Signed-off-by: Loic Poulain <loic.poulain@xxxxxxxxxx> > > > Are you still maintaining this driver ? Binghui's email seems to be invalid now. > > Regards, > Loic