On Wed, Feb 28, 2018 at 8:34 AM, Jan Kiszka <jan.kiszka@xxxxxxxxxxx> wrote: > From: Jan Kiszka <jan.kiszka@xxxxxxxxxxx> > > Not sure if those two worked by design or just by chance so far. In any > case, it's at least cleaner and clearer to express this in a single > config statement. I would add a reference to the commit which brought that in the first place. > > Signed-off-by: Jan Kiszka <jan.kiszka@xxxxxxxxxxx> > --- > arch/x86/Kconfig | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > index eb7f43f23521..63e85e7da12e 100644 > --- a/arch/x86/Kconfig > +++ b/arch/x86/Kconfig > @@ -2641,8 +2641,9 @@ config PCI_DIRECT > depends on PCI && (X86_64 || (PCI_GODIRECT || PCI_GOANY || PCI_GOOLPC || PCI_GOMMCONFIG)) > > config PCI_MMCONFIG > - def_bool y > - depends on X86_32 && PCI && (ACPI || SFI) && (PCI_GOMMCONFIG || PCI_GOANY) > + bool "Support mmconfig PCI config space access" if X86_64 > + default y > + depends on PCI && (ACPI || SFI) && (PCI_GOMMCONFIG || PCI_GOANY || X86_64) Looking to the above context I would rather put it like depends on PCI && (ACPI || SFI) && (X86_64 || (PCI_GOANY || PCI_GOMMCONFIG)) -- With Best Regards, Andy Shevchenko
