Re: [PATCH next V1 4/7] PCI: Print PCI device link status in kernel log

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2/25/2018 11:30 AM, Tal Gilboa wrote:
On 2/22/2018 9:57 PM, Bjorn Helgaas wrote:>
Suggested text:

   pci_info(dev, "available bandwidth %dGB/s (capable of %dGB/s)\n", ...

I'm not sure this merits a pci_warn().  In some cases a user might be
able to move the device to a different slot or something, but I'm sure
there are platforms where it is impossible for the user to do anything
about this, and I don't think we need to warn about that.

We face a lot of customer "bugs" due to lower than expected PCIe bandwidth. I think an info print would be too light in this case. Even if the user has nothing to do it should be aware of the problem.

We actually got some feedback saying the warnings are a bit too much. I'll remove most of them and change the remaining to pci_info().



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux