On 2/22/18 10:10 PM, Michael Ellerman wrote: > Bjorn Helgaas <helgaas@xxxxxxxxxx> writes: > >> On Thu, Feb 08, 2018 at 09:05:45AM -0600, Bryant G. Ly wrote: >>> On 2/8/18 6:20 AM, Michael Ellerman wrote: >>> >>>> There's no reason pci_uevent_ers() needs to be inline in pci.h, so >>>> move it out to a C file. >>>> >>>> Given it's used by AER the obvious location would be somewhere in >>>> drivers/pci/pcie/aer, but because it's also used by powerpc EEH code >>>> unfortunately that doesn't work in the case where EEH is enabled but >>>> PCIEPORTBUS is not. >>>> >>>> So for now put it in pci-driver.c, next to pci_uevent(), with an >>>> appropriate #ifdef so it's not built if AER and EEH are both disabled. >>>> >>>> While we're moving it also fix up the kernel doc comment for @pdev to >>>> be accurate. >>>> >>>> Reported-by: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> >>>> Signed-off-by: Michael Ellerman <mpe@xxxxxxxxxxxxxx> >>>> --- >>>> drivers/pci/pci-driver.c | 36 ++++++++++++++++++++++++++++++++++++ >>>> include/linux/pci.h | 38 +++----------------------------------- >>>> 2 files changed, 39 insertions(+), 35 deletions(-) >>> Looks good, thanks for fixing it! >>> >>> Signed-off-by: Bryant G. Ly <bryantly@xxxxxxxxxxxxxxxxxx> >> This would normally be a "Reviewed-by" unless you actually >> participated in developing the patch, and in that case, your >> "Signed-off-by" would normally be included in the original posting. >> >> What do you intend? I'll be glad to add either. > I wrote the patch, so Bryant meant Reviewed-by or maybe Acked-by. > > cheers > Yes, I mean't, Reviewed-by: Bryant G. Ly <bryantly@xxxxxxxxxxxxxxxxxx> Thanks, Bryant
