On Tue, Feb 13, 2018 at 11:45:15PM -0200, Fabio Estevam wrote: > Khuong Dinh, Lorenzo, > > On Wed, Dec 20, 2017 at 10:14 AM, Lorenzo Pieralisi > <lorenzo.pieralisi@xxxxxxx> wrote: > > [+ Khuong Dinh] > > > > On Tue, Dec 19, 2017 at 10:38:29PM -0200, Fabio Estevam wrote: > >> In the case of IS_ERR() error, we should return PTR_ERR(). > >> > >> Fix the error return code. > >> > >> Signed-off-by: Fabio Estevam <festevam@xxxxxxxxx> > >> --- > >> drivers/pci/host/pci-xgene-msi.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > > > > I am about to apply this patch, please let me know if you see > > any issue with that. > > A gente ping. Applied to pci/xgene for v4.17, sorry for the delay. Lorenzo > > Thanks, > > Lorenzo > > > >> diff --git a/drivers/pci/host/pci-xgene-msi.c b/drivers/pci/host/pci-xgene-msi.c > >> index 1f42a20..4a1fb01 100644 > >> --- a/drivers/pci/host/pci-xgene-msi.c > >> +++ b/drivers/pci/host/pci-xgene-msi.c > >> @@ -465,7 +465,7 @@ static int xgene_msi_probe(struct platform_device *pdev) > >> xgene_msi->msi_regs = devm_ioremap_resource(&pdev->dev, res); > >> if (IS_ERR(xgene_msi->msi_regs)) { > >> dev_err(&pdev->dev, "no reg space\n"); > >> - rc = -EINVAL; > >> + rc = PTR_ERR(xgene_msi->msi_regs); > >> goto error; > >> } > >> xgene_msi->msi_addr = res->start; > >> -- > >> 2.7.4 > >>