On 13-Feb-18 6:37 PM, Thierry Reding wrote: > On Tue, Jan 30, 2018 at 10:54:09AM +0530, Manikanta Maddireddy wrote: >> Implement remove callback function for Tegra PCIe driver to add >> loadable kernel module support. Change PCI_TEGRA config to tristate to >> allow pci-tegra driver to be build as a module. >> >> Signed-off-by: Manikanta Maddireddy <mmaddireddy@xxxxxxxxxx> >> Acked-by: Thierry Reding <treding@xxxxxxxxxx> >> --- >> V2: >> * no change in this patch >> V3: >> * use tegra_pcie_debugfs_exit() helper function in tegra_pcie_debugfs_init() >> V4: >> * no change in this patch >> V5: >> * Decoupled from https://patchwork.ozlabs.org/patch/832053/ and >> rebased on linux-next >> V6: >> * no change in this patch >> V7: >> * no change in this patch >> >> drivers/pci/host/Kconfig | 2 +- >> drivers/pci/host/pci-tegra.c | 34 +++++++++++++++++++++++++++++++--- >> 2 files changed, 32 insertions(+), 4 deletions(-) > > Trying to build this as a module I get a link failure because > irq_set_msi_desc() is not exported. I thought a patch to do that had > been part of an earlier version of this series. Has that not been merged > yet? > > Thierry > I got a review comment to use generic MSI model instead of deprecated API. source: https://patchwork.ozlabs.org/patch/841111/ Also arm32 compilation will fail because of missing EXPORT of tegra_cpuidle_pcie_irqs_in_use() source: https://patchwork.ozlabs.org/patch/841119/ I need to put some time to prepare patches for these two cases. Meanwhile I want to get the basic driver structure for LKM to be merged. I verified locally with these two symbols exported.
