Convert ROM read access enable/disable string parsing to use the `kstrtobool` function. This fixes Bugzilla Bug 111301 -- Sysfs PCI rom file functionality does not match documentation. bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=111301 Reported-by: googlegot@xxxxxxxxx Signed-off-by: Kenny Ballou <kballou@xxxxxxxxxxxxxx> --- drivers/pci/pci-sysfs.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c index eb6bee8724cc..3cde1f25e786 100644 --- a/drivers/pci/pci-sysfs.c +++ b/drivers/pci/pci-sysfs.c @@ -1424,10 +1424,12 @@ static ssize_t pci_write_rom(struct file *filp, struct kobject *kobj, { struct pci_dev *pdev = to_pci_dev(kobj_to_dev(kobj)); - if ((off == 0) && (*buf == '0') && (count == 2)) - pdev->rom_attr_enabled = 0; - else + bool res = false; + + if (kstrtobool(buf, &res) == 0 && res) pdev->rom_attr_enabled = 1; + else + pdev->rom_attr_enabled = 0; return count; } -- 2.13.6
