On Tue, Jan 30, 2018 at 01:11:00PM -0600, Bjorn Helgaas wrote: > On Tue, Jan 30, 2018 at 11:57:58AM -0700, Keith Busch wrote: > > On Tue, Jan 30, 2018 at 12:26:48PM -0600, Bjorn Helgaas wrote: > > > + u16 cap = dpc->cap_pos; > > > + u32 status, mask; > > > + u32 sev, syserr, exc; > > > + u16 dpc_status, first_error; > > > + u32 dw0, dw1, dw2, dw3; > > > + u32 log; > > > + u32 prefix; > > > > Minor nit, could you squash the declarations of the same type? > > I did it that way so it matches the order of the chunks of code where > they're used. But I guess we don't really do that elsewhere in the > file, so I did. Here's the result: Thanks! That's all I had on this series. Looks good to me! Reviewed-by: Keith Busch <keith.busch@xxxxxxxxx>
