On 30 January 2018 at 08:38, Bjorn Helgaas <helgaas@xxxxxxxxxx> wrote: > On Tue, Jan 30, 2018 at 07:43:21AM +1000, Dave Airlie wrote: >> On 3 January 2018 at 22:44, Sinan Kaya <okaya@xxxxxxxxxxxxxx> wrote: >> > On 12/19/2017 12:37 AM, Sinan Kaya wrote: >> >> pci_get_bus_and_slot() is restrictive such that it assumes domain=0 as >> >> where a PCI device is present. This restricts the device drivers to be >> >> reused for other domain numbers. >> >> So not a major problem, but it would be pretty much impossible for either >> of these agp drivers to be used in any other domain ever. >> >> What does this buy us, maybe just rename pci_get_bus_and_slot to >> pci_get_domain0_bus_and_slot as a helper, or just pass the pdev in >> and have it do the right thing always. > > I already have this patch on my "next" branch, planned for the v4.16 > merge window, so it's done unless you have a major objection. Yeah I don't really care either way, I just can't seen the point in changing agp drivers that definitely will never see a domain, but if it gets rid of a dumb API, so be it. Dave.
