On Mon, Jan 22, 2018 at 03:33:52PM -0800, Dmitry Torokhov wrote: > On Sun, Jan 21, 2018 at 10:15:39PM +0100, Ladislav Michl wrote: > > devm_pci_remap_cfgspace() is using devm_ioremap_release() > > devres release function. Move it to devres along with > > similar PCI functions to allow hiding devm_ioremap_release() > > from public. > > So we are sharing this function: > > void devm_ioremap_release(struct device *dev, void *res) > { > iounmap(*(void __iomem **)res); > } > > and we want to hide it, and for that we are moving a lot of PCI-specific > stuff into lib/devres.c. If anything, I'd say we should move more PCI > stuff _out_ of lib/devres.c, and if we wait to make local copy and call > it devm_pci_cfgspace_release() that woudl be fine with me. Well, that's fine with me too. Will send v2 without all these changes. > Anyway, up to the maintainers. > > Thanks. Thank you, ladis