On Mon, Jan 22, 2018 at 10:50:57PM +0100, Ladislav Michl wrote: > On Mon, Jan 22, 2018 at 09:49:03AM -0800, Dmitry Torokhov wrote: > > On Sun, Jan 21, 2018 at 10:15:08PM +0100, Ladislav Michl wrote: > > > Moving managed io function declarations into device.h allows > > > removing forward struct device and resource definitions from > > > io(port).h > > > > In the face of it, what is the issue with forward declarations of device > > and resource structures? device.h is supposed to be about Linux device > > model, not hardware. You would not want all devm_* functions to go into > > device.h (clock, regulator, input, rtc, hwmon, etc, etc devm API), > > right? Why would we want ioport there? > > Allright, point taken. Then I would assume devm_ioremap_resource should > be moved from device.h into io.h, to get some consistency, right? Yes, I think that would be good. > Any other comment (mainly to devm_ioremap_shared_resource) before v2? > > Thank you, > ladis Thanks. -- Dmitry
