On 1/18/2018 12:32 AM, poza@xxxxxxxxxxxxxx wrote:
> On 2018-01-18 08:26, Keith Busch wrote:
>> On Wed, Jan 17, 2018 at 08:27:39AM -0800, Sinan Kaya wrote:
>>> On 1/17/2018 5:37 AM, Oza Pawandeep wrote:
>>> > +static bool dpc_wait_link_active(struct pci_dev *pdev)
>>> > +{
>>>
>>> I think you can also make this function common instead of making another copy here.
>>> Of course, this would be another patch.
>>
>> It is actually very similar to __pcie_wait_link_active in pciehp_hpc.c,
>> so there's some opprotunity to make even more common code.
>
> in that case there has to be a generic function in
> drives/pci.c
>
> which addresses folowing functions from
>
> pcie-dpc.c:
> dpc_wait_link_inactive
> dpc_wait_link_active
>
> drivers/pci/hotplug/pciehp_hpc.c
> pcie_wait_link_active
>
>
> all aboe making one generic function to be moved to drives/pci.c
>
> please let me know if this is okay.
Works for me. Keith/Bjorn?
>
> Regards,
> Oza.
>
>
--
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
