On Thu, Jan 11, 2018 at 8:04 PM, Borislav Petkov <bp@xxxxxxx> wrote: > On Thu, Jan 11, 2018 at 07:03:23PM +0100, Rafael J. Wysocki wrote: >> >> > + if (!(requested & control & OSC_PCI_EXPRESS_AER_CONTROL)) >> >> >> >> One of the operators above needs to be a && I suppose? >> >> >> > >> > It's a 3-way bitwise AND to check that OSC_PCI_EXPRESS_AER_CONTROL is >> > set in both "requested" and "control". >> > >> > IOW, we check if AER was requested by the OS and that the platform >> > granted the request. >> >> OK > > This definitely needs a comment - people will keep tripping over this. Fair enough.
