On Thu, 2017-12-28 at 17:22 -0600, Bjorn Helgaas wrote: > Both paths end up calling the pci_error_handlers.error_detected() > hook. > > Drivers are not supposed to care what arch they're running on. If the > driver supplies an .error_detected() entry point, it's up to the PCI > core and powerpc code to use it consistently across arches. That > means the same uevents (if any) should be emitted from both paths. > > The best way would be to unify the call of .error_detected() so the > AER path and the powerpc path do it via the same function. The AER > report_error_detected() and the powerpc eeh_report_error() do look > fairly similar, so this seems possible in principle, but I'm not > holding my breath. Factoring these callers into a common function that can then do the uevent for errors makes a lot of sense. The "resume" path might be trickier, but even then, rather than calling directly the driver op, it would be easy to have a little wrapper that does it, which can then also do the uevent. Ben.
