On Wed, 2017-12-27 at 09:30 -0600, Rob Herring wrote: > On Tue, Dec 26, 2017 at 7:32 PM, JeffyChen <jeffy.chen@xxxxxxxxxxxxxx> > wrote: > this new file does something similar to the pci-acpi.c and pci-mid.c.. > pci-acpi.c has similar things to pci/of.c. The naming is just not > consistent. > > and i am agree the naming is not clear, maybe we can rename both of > > those > > files to something like pci-pm-***.c? > > At least pci-acpi.c is more than just PM functions, so that doesn't > make sense. Given that all the ACPI related functions are in 1 file, > we should do the same for DT. > > but i have no idea about pci-mid.c or would it possible to have more > > platform pm ops in the future...maybe we should add some dependency > > in the > > Kconfig? You may consider pci-mid.c as pci-sfi.c to some extend. So, in that sense it more looks like pci-of.c would be the name for DT case. -- Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> Intel Finland Oy