Re: [PATCH] qed: Remove unused QED_RDMA_DEV_CAP_* symbols and dev->dev_caps

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: David Miller <davem@xxxxxxxxxxxxx>
Date: Mon, 18 Dec 2017 15:13:54 -0500 (EST)

> From: Bjorn Helgaas <helgaas@xxxxxxxxxx>
> Date: Fri, 15 Dec 2017 17:03:01 -0600
> 
>> From: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
>> 
>> The QED_RDMA_DEV_CAP_* symbols are only used to set bits in dev->dev_caps.
>> Nobody ever looks at those bits.  Remove the symbols and dev_caps itself.
>> 
>> Note that if these are ever used and added back, it looks incorrect to set
>> QED_RDMA_DEV_CAP_ATOMIC_OP based on PCI_EXP_DEVCTL2_LTR_EN.  LTR is the
>> Latency Tolerance Reporting mechanism, which has nothing to do with Atomic
>> Ops.
>> 
>> No functional change intended.
>> 
>> Signed-off-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
> 
> Applied to net-next.

Actually, this doesn't build, reverted:

drivers/infiniband/hw/qedr/main.c: In function ʽqedr_set_device_attrʼ:
drivers/infiniband/hw/qedr/main.c:682:27: error: ʽstruct qed_rdma_deviceʼ has no member named ʽdev_capsʼ
  attr->dev_caps = qed_attr->dev_caps;




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux