On Fri 2017-12-08 17:24:22, Sergey Senozhatsky wrote: > Move local "sched.h" include to the bottom. sched.h defines > several macros that are getting redefined in ARCH-specific > code, for instance, finish_arch_post_lock_switch() and > prepare_arch_switch(), so we need ARCH-specific definitions > to come in first. This patch is needed to fix compilation error [1] caused by a patchset that deprecates %pf/%pF printk modifiers[2]. IMHO, we should make sure that this fix goes into Linus' tree before the printk-related patchset. What is the best practice, please? I see two reasonable possibilities. Either sched people could push this for-4.15-rcX. Or I could put it into printk.git for-4.16 in the right order. What do you think? Referece: [0] http://lkml.kernel.org/r/201712080259.tvO64XfA%fengguang.wu@xxxxxxxxx [1] https://git.kernel.org/pub/scm/linux/kernel/git/pmladek/printk.git/commit/?h=for-next&id=98fff2c57b7e88d643cb42ffd910fe9905b33176 Best Regards, Petr