Marc, I have dropped this patch off from the patch series. I will look into generic handling of MSI too. Thanks. On Wed, Nov 22, 2017 at 1:32 PM, Marc Zyngier <marc.zyngier@xxxxxxx> wrote: > On Thu, 9 Nov 2017 10:42:06 +0530 > subrahmanya l <l.subrahmanya@xxxxxxxxxxxxxx> wrote: > >> Christoph, >> >> Xilinx MSI driver uses it. >> >> file path: https://github.com/Xilinx/linux-xlnx/blob/master/drivers/pci/host/pcie-xilinx.c#L286 >> >> I used the same driver as reference to write another Rootport driver >> which needs it too. > > You shouldn't need this at all. The driver you are looking at is using > a deprecated API, and you should implement the MSI part of your driver > using the generic MSI layer which takes care of this and shouldn't > require exporting this function. > > There is a number of drivers in the tree that have been converted to > generic MSI, such as pcie-tango.c for example. > > Thanks, > > M. > -- > Without deviation from the norm, progress is not possible.
