On Thu, Nov 23, 2017 at 4:11 PM, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > On Thu, Nov 23, 2017 at 04:04:22PM +0200, Oded Gabbay wrote: >> Add PCI codes to include/linux/pci_ids.h for Processing Accelerators. There >> are new ASICs (now in development) for Deep Learning that will utilize this >> base class. >> >> Signed-off-by: Oded Gabbay <oded.gabbay@xxxxxxxxx> >> --- >> include/linux/pci_ids.h | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h >> index ab20dc5..4c210cd 100644 >> --- a/include/linux/pci_ids.h >> +++ b/include/linux/pci_ids.h >> @@ -139,6 +139,9 @@ >> #define PCI_CLASS_SP_DPIO 0x1100 >> #define PCI_CLASS_SP_OTHER 0x1180 >> >> +#define PCI_BASE_CLASS_PROCESSING_ACCELERATOR 0x12 >> +#define PCI_CLASS_PA_VENDOR_SPECIFIC 0x1200 > > Did you read the top of this file? Yes, but I thought that since this value is defined in the PCI spec then it is ok to add it here. > > And if these really do belong here, then it should go in as part of a > patch series that contains a driver that uses these values. ok, then I'll need to resend this in a couple of months. Thanks, Oded > > thanks, > > greg k-h