On 11/17/2017 7:02 PM, Bjorn Helgaas wrote: >> What do you think about the rescan following link up? The only entity >> that does rescan today is hotplug after DPC recovery. There could be >> a platform with DPC support but no hotplug support. >> >> How should we handle it? > Good question. If your system does support both DPC and hotplug, I > assume the link comes back up after you clear DPC Trigger Status. > Does pciehp notice that "link up" event and add the device back? that's correct. we see a link up indication from hotplug driver followed by a rescan. > > So I think your question is whether the DPC code should explicitly do > a rescan so that if we don't have pciehp, we'll still automatically > rediscover the device. I dunno, maybe. Seems like a plausible idea > anyway. OK, will add it to DPC driver for completeness. -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.