On 11/08/2017 12:00 PM, Sergei Shtylyov wrote: > On 11/8/2017 12:28 PM, Marek Vasut wrote: > >> From: Kazufumi Ikeda <kaz-ikeda@xxxxxxxxxxxxx> >> >> Reestablish the PCIe link very early in the resume process in case it >> went down to prevent PCI accesses from hanging the bus. Such accesses >> can happen early in the PCI resume process, in the resume_noirq, thus >> the link must be reestablished in the resume_noirq callback of the >> driver. >> >> Signed-off-by: Kazufumi Ikeda <kaz-ikeda@xxxxxxxxxxxxx> >> Signed-off-by: Gaku Inami <gaku.inami.xw@xxxxxxxxxxxxxx> >> Signed-off-by: Marek Vasut <marek.vasut+renesas@xxxxxxxxx> >> Cc: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> >> Cc: Simon Horman <horms+renesas@xxxxxxxxxxxx> >> Cc: Wolfram Sang <wsa@xxxxxxxxxxxxx> >> Cc: linux-renesas-soc@xxxxxxxxxxxxxxx >> --- >> drivers/pci/host/pcie-rcar.c | 31 ++++++++++++++++++++++++++++--- >> 1 file changed, 28 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/pci/host/pcie-rcar.c b/drivers/pci/host/pcie-rcar.c >> index 889603783f01..aa588a7d4811 100644 >> --- a/drivers/pci/host/pcie-rcar.c >> +++ b/drivers/pci/host/pcie-rcar.c > [...] >> @@ -529,7 +530,7 @@ static void phy_write_reg(struct rcar_pcie *pcie, >> phy_wait_for_ack(pcie); >> } >> -static int rcar_pcie_wait_for_dl(struct rcar_pcie *pcie) >> +static int rcar_pcie_wait_for_dl(struct rcar_pcie *pcie, int atomic) > > How about *bool* atomic? Not a big fan of bool in C, but I think I can avoid this altogether. If I poll more often, I can just use udelay(5) for such a short delay. > [...] > > MBR, Sergei -- Best regards, Marek Vasut
