On Thursday 09 November 2017 02:55 AM, Bjorn Helgaas wrote:
[+cc Michal, Sören, Simon]
On Mon, Nov 06, 2017 at 11:33:07PM +0530, Vidya Sagar wrote:
limits MSI target address to only 32-bit region to enable
some of the PCIe end points where only 32-bit MSIs
are supported work properly.
One example being Marvel SATA controller
Signed-off-by: Vidya Sagar <vidyas@xxxxxxxxxx>
---
drivers/pci/host/pci-tegra.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/host/pci-tegra.c b/drivers/pci/host/pci-tegra.c
index 1987fec1f126..03d3dcdd06c2 100644
--- a/drivers/pci/host/pci-tegra.c
+++ b/drivers/pci/host/pci-tegra.c
@@ -1531,7 +1531,7 @@ static int tegra_pcie_enable_msi(struct tegra_pcie *pcie)
}
/* setup AFI/FPCI range */
- msi->pages = __get_free_pages(GFP_KERNEL, 0);
+ msi->pages = __get_free_pages(GFP_DMA, 0);
msi->phys = virt_to_phys((void *)msi->pages);
Should this be GFP_DMA32? See the comment above the GFP_DMA
definition.
looking at the comments for both GFP_DMA32 and GFP_DMA, I thought GFP_DMA32
is the correct one to use, but, even with that I got >32-bit addresses.
GFP_DMA always gives addresses in <4GB boundary (i.e. 32-bit).
I didn't dig into it to find out why is this the case.
Should we be using virt_to_phys() here? Where exactly is the result
("msi->phys") used, i.e., what bus will that address appear on? If it
appears on the PCI side, this should probably use something like
pcibios_resource_to_bus().
This address is written to two places.
First, into host's internal register to let it know that when an incoming
memory write comes with this address, raise an MSI interrupt instead of
forwarding it to
memory subsystem.
Second, into 'Message Address' field of 'Message Address Register for
MSI' register in
end point's configuration space (this is done by MSI framework) for end
point to know
which address to be used to generate MSI interrupt.
Do rcar_pcie_enable_msi() and xilinx_pcie_enable_msi() have a similar
problem? They both use GFP_KERNEL, then virt_to_phys(), then write the
result of virt_to_phys() using a 32-bit register write.
Well, if those systems deal with 64-bit addresses and when an end point
is connected which supports
only 32-bit MSI addresses, this problem will surface when
__get_free_pages() returns an address that
translates to a >32-bit address after virt_to_phys() call on it.
afi_writel(pcie, msi->phys >> soc->msi_base_shift, AFI_MSI_FPCI_BAR_ST);
--
2.7.4
