On 10/31/2017 07:22 AM, Kishon Vijay Abraham I wrote: (snip) >> --- a/drivers/pci/dwc/pcie-designware.h >> +++ b/drivers/pci/dwc/pcie-designware.h >> @@ -106,6 +106,8 @@ >> #define MSI_CAP_MME_MASK (7 << MSI_CAP_MME_SHIFT) >> #define MSI_MESSAGE_ADDR_L32 0x54 >> #define MSI_MESSAGE_ADDR_U32 0x58 >> +#define MSI_MESSAGE_DATA_32 0x58 > > Does ADDR_U32 and DATA_32 share the same offset? (in dra7xx MSI_64_EN is > hardwired to 1 so I can't know this for sure.) > Hello Kishon, Yes, they do. The information in the register depends on if the bit MSI_64_EN is set or not. There exists defines for this also in the generic uapi header pci_regs.h, however, utilizing that header would be a separate patch. $ grep -E "MSI_DATA|MSI_MASK" include/uapi/linux/pci_regs.h #define PCI_MSI_DATA_32 8 /* 16 bits of data for 32-bit devices */ #define PCI_MSI_MASK_32 12 /* Mask bits register for 32-bit devices */ #define PCI_MSI_DATA_64 12 /* 16 bits of data for 64-bit devices */ #define PCI_MSI_MASK_64 16 /* Mask bits register for 64-bit devices */ Regards, Niklas
