Hi Brian,
On 10/27/2017 01:55 PM, Brian Norris wrote:
One reason this series is failing for me: the above is failing with
-EINVAL -- it seems like no one set the 'can_wakeup' flag for the
Marvell Wifi card I'm using. It seems like we probably*should* be
calling device_set_wakeup_capable() from your new setup method, to say
that we're capable of wakeup. The PCI PME code does this already, which
seems to make sense. There are also some network drivers that do it too
(e.g., ath10k), but not all.
right, thanks for noticing, will fix it in the new version...
and Sinan suggested to separate of code and wakeirq handling, would it
make sense to rewrite this as pci-wakeirq.c(platform_pm_ops based on
irq), and move of parse code into drivers/of/(maybe into
of_irq_parse_pci()'s PCI interrupt parsing code)?
Brian
