On 10/13/2017 06:09 PM, Niklas Cassel wrote: (snip) Hello Kishon I just wanted to say that the function artpec6_pcie_calc_cpu_fixup_mask should work on dra7xx as well. (I had dra7xx in mind when I wrote it.) However, I did not want to change pci-dra7xx.c to also use this function, since your current code is quite simple. But if you think that it's a good idea, we could rename and move artpec6_pcie_calc_cpu_fixup_mask to pcie-designware.c, and migrate pci-dra7xx to utilize this function as well, as it is strictly more correct to use values from device tree, rather than having a hard coded define in the SoC driver. Regards, Niklas
