+ gkh, maz, tglx, linus w
On 15/10/2017 00:07, Fabio Estevam wrote:
> When platform_get_irq() fails we should propagate the real error value
> instead of always returning -ENXIO.
>
> Cc: Marc Gonzalez <marc_gonzalez@xxxxxxxxxxxxxxxx>
> Signed-off-by: Fabio Estevam <festevam@xxxxxxxxx>
> ---
> drivers/pci/host/pcie-tango.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/host/pcie-tango.c b/drivers/pci/host/pcie-tango.c
> index e23f738..5196583 100644
> --- a/drivers/pci/host/pcie-tango.c
> +++ b/drivers/pci/host/pcie-tango.c
> @@ -272,9 +272,9 @@ static int tango_pcie_probe(struct platform_device *pdev)
> writel_relaxed(0, pcie->base + SMP8759_ENABLE + offset);
>
> virq = platform_get_irq(pdev, 1);
> - if (virq <= 0) {
> + if (virq < 0) {
> dev_err(dev, "Failed to map IRQ\n");
> - return -ENXIO;
> + return virq;
> }
>
> irq_dom = irq_domain_create_linear(fwnode, MSI_MAX, &dom_ops, pcie);
Hello Fabio,
I don't think this patch is correct.
AFAIU, on all but legacy platforms, when platform_get_irq() returns 0,
it is to signal an error condition.
Marc Z pointed out this discussion:
http://yarchive.net/comp/linux/zero.html
Looking more closely at the platform_get_irq implementation, and ignoring
the CONFIG_SPARC special-case, the return value is either:
* a valid virq > 0, or
* -EPROBE_DEFER, or
* some error code < 0, in the ACPI case, or
* -ENXIO, or
* res->start (an unsigned type, so >= 0)
I suppose it would be slightly nicer to write:
virq = platform_get_irq(pdev, 1);
if (virq <= 0)
return virq ? virq : -ENODEV;
Regards.
