Acked-by: Niklas Cassel <niklas.cassel@xxxxxxxx>
On 08/31/2017 07:52 PM, Fabio Estevam wrote:
> platform_get_irq() returns a negative number on failure, so
> adjust the logic to detect such condition and propagate
> the real error value on failure.
>
> Cc: Niklas Cassel <niklas.cassel@xxxxxxxx>
> Signed-off-by: Fabio Estevam <fabio.estevam@xxxxxxx>
> ---
> drivers/pci/dwc/pcie-artpec6.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/dwc/pcie-artpec6.c b/drivers/pci/dwc/pcie-artpec6.c
> index 5d81f1d..83d6ee0 100644
> --- a/drivers/pci/dwc/pcie-artpec6.c
> +++ b/drivers/pci/dwc/pcie-artpec6.c
> @@ -209,9 +209,9 @@ static int artpec6_add_pcie_port(struct artpec6_pcie *artpec6_pcie,
>
> if (IS_ENABLED(CONFIG_PCI_MSI)) {
> pp->msi_irq = platform_get_irq_byname(pdev, "msi");
> - if (pp->msi_irq <= 0) {
> + if (pp->msi_irq < 0) {
> dev_err(dev, "failed to get MSI irq\n");
> - return -ENODEV;
> + return pp->msi_irq;
> }
>
> ret = devm_request_irq(dev, pp->msi_irq,
>
