Re: [PATCH 1/2 v2] PCI: v3: Update the device tree bindings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Aug 22, 2017 at 9:09 PM, Bjorn Helgaas <helgaas@xxxxxxxxxx> wrote:

> On Wed, Aug 09, 2017 at 04:14:54PM +0200, Linus Walleij wrote:
>> The bindings for the V3 Semiconductor PCI bridge are a tad bit outdated
>> and predates the more formal format we have adopted for the bindings.
>> Update them a bit so it is easier to read, and add the Integrator AP-
>> specific compatible so we can detect that we are running on that specific
>> platform.
>>
>> Acked-by: Rob Herring <robh@xxxxxxxxxx>
>> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
(...)
>> -- reg: should contain the base address of the V3 adapter.
>> +Required properties:
>> +- compatible: should be one of:
>> +  "v3,v360epc-pci"
>> +  "arm,integrator-ap-pci", "v3,v360epc-pci"
>> +- reg: should contain the base address of the V3 host bridge.
>
> Does this need some sort of comment about how the non-pref and pref mem
> windows need to be 256Mb and adjacent?  I think the driver makes some
> unverified assumptions about them.

Yeah that is how I understand that it works as well. I will document
this in the binding.

Yours,
Linus Walleij



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux