Re: [PATCH 02/10] PCI: dra7xx: Fix platform_get_irq() error handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Thursday 31 August 2017 11:22 PM, Fabio Estevam wrote:
> When platform_get_irq() fails we should propagate the real error
> value instead of always returning -EINVAL.
> 
> Cc: Kishon Vijay Abraham I <kishon@xxxxxx>
> Signed-off-by: Fabio Estevam <fabio.estevam@xxxxxxx>

Acked-by: Kishon Vijay Abraham I <kishon@xxxxxx>
> ---
>  drivers/pci/dwc/pci-dra7xx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/dwc/pci-dra7xx.c b/drivers/pci/dwc/pci-dra7xx.c
> index e0dd98d..1e2aaed 100644
> --- a/drivers/pci/dwc/pci-dra7xx.c
> +++ b/drivers/pci/dwc/pci-dra7xx.c
> @@ -450,7 +450,7 @@ static int __init dra7xx_add_pcie_port(struct dra7xx_pcie *dra7xx,
>  	pp->irq = platform_get_irq(pdev, 1);
>  	if (pp->irq < 0) {
>  		dev_err(dev, "missing IRQ resource\n");
> -		return -EINVAL;
> +		return pp->irq;
>  	}
>  
>  	ret = devm_request_irq(dev, pp->irq, dra7xx_pcie_msi_irq_handler,
> 



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux