On Mon, Aug 28, 2017 at 11:33:53AM +0800, Honghui Zhang wrote:
> On Sat, 2017-08-26 at 14:20 +0000, Li, Philip wrote:
> > > On Sat, Aug 26, 2017 at 06:55:08AM -0500, Bjorn Helgaas wrote:
> > > >On Sat, Aug 26, 2017 at 08:56:27AM +0800, Ryder Lee wrote:
> > > >> Hi,
> > > >>
> > > >> On Fri, 2017-08-25 at 08:53 +0800, Honghui Zhang wrote:
> > > >> > On Thu, 2017-08-24 at 08:44 -0500, Bjorn Helgaas wrote:
> > > >> > > On Thu, Aug 24, 2017 at 11:14:07AM +0800, mtk11102 wrote:
> > > >> > > > On Wed, 2017-08-23 at 17:52 -0500, Bjorn Helgaas wrote:
> > > >> > > > > On Wed, Aug 23, 2017 at 10:53:07PM +0800, kbuild test robot wrote:
> > > >>
> > > >> ....
> > > >> > > > I pull the your host-mediatek branch and seems the build error is still
> > > >> > > > there.
> > > >> > > > Should I send a new patch base on your pci/host-mediatek to fix the
> > > >> > > > build warnings, or should I wait for your push for build error and then
> > > >> > > > send the patch?
> > > >> > >
> > > >> > > Sorry, I must have forgotten to push it. Should be there now:
> > > >> > > 9f3ec1e47377 ("PCI: mediatek: Add MSI support for MT2712 and MT7622")
> > > >> > >
> > > >> > > Hopefully that has everything we need (I included your fix above).
> > > >> > >
> > > >> >
> > > >> > Thanks very much for your help.
> > > >> >
> > > >> > > Bjorn
> > > >> >
> > > >> >
> > > >>
> > > >> I just noticed that 9f3ec1e47377 could not be built pass.
> > > >>
> > > >> In function 'mtk_pcie_enable_msi':
> > > >> error: 'return' with a value, in function returning void [-Werror]
> > > >> return 0;
> > > >>
> > > >> In function 'mtk_pcie_init_irq_domain': error: unused variable
> > > >> 'err' [-Werror=unused-variable]
> > > >> int err;
> > > >
> > > >Fixed in 0eb463c096c4 ("PCI: mediatek: Add MSI support for MT2712 and
> > > >MT7622").
> > > >
>
> Hi, Bjorn,
> Seems you forget to remove the following define in 0eb463c096c4 :
>
> > >> In function 'mtk_pcie_init_irq_domain': error: unused variable
> > > >> 'err' [-Werror=unused-variable]
> > > >> int err;
Removed, thanks.
