On Tue, Aug 22, 2017 at 11:19:33AM +0800, Jeffy Chen wrote:
> Add an optional interrupt for PCIE_WAKE pin.
Rob?
> Signed-off-by: Jeffy Chen <jeffy.chen@xxxxxxxxxxxxxx>
> ---
>
> Changes in v4: None
> Changes in v3: None
> Changes in v2: None
>
> .../devicetree/bindings/pci/rockchip-pcie.txt | 20 ++++++++++++--------
> 1 file changed, 12 insertions(+), 8 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pci/rockchip-pcie.txt b/Documentation/devicetree/bindings/pci/rockchip-pcie.txt
> index 5678be82530d..9f6504129e80 100644
> --- a/Documentation/devicetree/bindings/pci/rockchip-pcie.txt
> +++ b/Documentation/devicetree/bindings/pci/rockchip-pcie.txt
> @@ -20,10 +20,13 @@ Required properties:
> - msi-map: Maps a Requester ID to an MSI controller and associated
> msi-specifier data. See ./pci-msi.txt
> - interrupts: Three interrupt entries must be specified.
> -- interrupt-names: Must include the following names
> - - "sys"
> - - "legacy"
> - - "client"
> +- interrupt-names: Include the following names
> + Required:
> + - "sys"
> + - "legacy"
> + - "client"
> + Optional:
> + - "wake"
Why is there no other PCI binding that includes "wake" as an
interrupt-name? This feels like something that should be fairly
common across host controllers. I don't want a Rockport-specific
DT description if it could be made more general.
> - resets: Must contain seven entries for each entry in reset-names.
> See ../reset/reset.txt for details.
> - reset-names: Must include the following names
> @@ -87,10 +90,11 @@ pcie0: pcie@f8000000 {
> clock-names = "aclk", "aclk-perf",
> "hclk", "pm";
> bus-range = <0x0 0x1>;
> - interrupts = <GIC_SPI 49 IRQ_TYPE_LEVEL_HIGH 0>,
> - <GIC_SPI 50 IRQ_TYPE_LEVEL_HIGH 0>,
> - <GIC_SPI 51 IRQ_TYPE_LEVEL_HIGH 0>;
> - interrupt-names = "sys", "legacy", "client";
> + interrupts-extended = <&gic GIC_SPI 49 IRQ_TYPE_LEVEL_HIGH 0>,
> + <&gic GIC_SPI 50 IRQ_TYPE_LEVEL_HIGH 0>,
> + <&gic GIC_SPI 51 IRQ_TYPE_LEVEL_HIGH 0>,
> + <&gpio0 8 IRQ_TYPE_LEVEL_LOW>;
> + interrupt-names = "sys", "legacy", "client", "wake";
> assigned-clocks = <&cru SCLK_PCIEPHY_REF>;
> assigned-clock-parents = <&cru SCLK_PCIEPHY_REF100M>;
> assigned-clock-rates = <100000000>;
> --
> 2.11.0
>
>
