On 24 August 2017 at 17:48, Robin Murphy <robin.murphy@xxxxxxx> wrote: > Hi Ard, > > On 21/08/17 20:29, Ard Biesheuvel wrote: > [...] >> +static int dw_pcie_msi_probe(struct platform_device *pdev) >> +{ >> + struct fwnode_handle *fwnode = of_node_to_fwnode(pdev->dev.of_node); > > Mini-nit: since fairly recently (f94277af03ea) dev->fwnode should > already be set appropriately by of_platform_device_create(), so you > should be able to make this entirely firmware-agnostic if you like. > Thanks for pointing that out. I'm not sure yet what it means exactly, but I'm sure I will figure it out :-)