On 22/08/2017 18:29, Marc Zyngier wrote: > On 22/08/17 15:56, Marc Gonzalez wrote: > >> #define SMP8759_MUX 0x48 >> #define SMP8759_TEST_OUT 0x74 >> +#define SMP8759_STATUS 0x80 >> +#define SMP8759_ENABLE 0xa0 >> +#define SMP8759_DOORBELL 0xa002e07c > > Why is this hardcoded and not coming from the device-tree, just like any > other address property? Since this bus address is software-configurable, I didn't think it belonged in the DT. Also, I didn't see anything similar in other binding docs, especially Documentation/devicetree/bindings/interrupt-controller/msi.txt Regards.