Re: PCI/IB: add support for pci driver attribute groups

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2017-08-01 at 16:40 -0500, Bjorn Helgaas wrote:
> On Wed, Jul 19, 2017 at 03:01:06PM +0200, Greg KH wrote:
> > From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > 
> > Some drivers (specifically the nes IB driver), want to create a lot
> > of
> > sysfs driver attributes.  Instead of open-coding the creation and
> > removal of these files (and getting it wrong btw), it's a better
> > idea to
> > let the driver core handle all of this logic for us.
> > 
> > So add a new field to the pci driver structure, **groups, that
> > allows
> > pci drivers to specify an attribute group list it wishes to have
> > created
> > when it is registered with the driver core.
> > 
> > Big bonus is now the driver doesn't race with userspace when the
> > sysfs
> > files are created vs. when the kobject is announced, so any
> > script/tool
> > that actually wanted to use these files will not have to poll
> > waiting
> > for them to show up.
> > 
> > Cc: Faisal Latif <faisal.latif@xxxxxxxxx>
> > Cc: Doug Ledford <dledford@xxxxxxxxxx>
> > Cc: Sean Hefty <sean.hefty@xxxxxxxxx>
> > Cc: Hal Rosenstock <hal.rosenstock@xxxxxxxxx>
> > Cc: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> 
> Acked-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
> 
> If you want me to take this let me know; otherwise I'll assume Doug
> will
> merge it.

I've picked it up for for-next.  Thanks.

-- 
Doug Ledford <dledford@xxxxxxxxxx>
    GPG KeyID: B826A3330E572FDD
    Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux