Re: [RFC PATCH v2 1/3] PCI: rockchip: Add support for pcie wake irq

[jeffy <jeffy.chen@xxxxxxxxxxxxxx>]

Hi Shawn,

On 08/18/2017 03:23 PM, Shawn Lin wrote:
> > @@ -1524,6 +1532,9 @@ static int rockchip_pcie_remove(struct
> > platform_device *pdev)
> >       struct device *dev = &pdev->dev;
> >       struct rockchip_pcie *rockchip = dev_get_drvdata(dev);
> > +    dev_pm_clear_wake_irq(dev);
> > +    device_init_wakeup(dev, false);
> > +
>
> Looks good overall but I think we need this on the
> error handling path of rockchip_pcie_probe as well?

hmm, right, will fix it, thanks.

and i also notice some other missing error handling, will fix them too:)