Hi Bjorn, On 08/15/2017 01:26 AM, Bjorn Helgaas wrote: > [+cc Stanimir, Niklas, Jesper] > > On Mon, Aug 14, 2017 at 04:38:24PM -0500, Bjorn Helgaas wrote: >> On Thu, Aug 03, 2017 at 04:23:38PM +0800, Zhiqiang Hou wrote: >>> From: Hou Zhiqiang <Zhiqiang.Hou@xxxxxxx> >>> >>> Make the ls1021a's host_init reuse layerscape platform's common >>> host_init function. >>> >>> Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@xxxxxxx> >>> --- >>> V2: >>> - Removed the disable outbound windows code and the remove duplicate class code >>> fixup code from this patch. >>> >>> drivers/pci/dwc/pci-layerscape.c | 54 ++++++++++++++++++++-------------------- >>> 1 file changed, 27 insertions(+), 27 deletions(-) >>> >>> diff --git a/drivers/pci/dwc/pci-layerscape.c b/drivers/pci/dwc/pci-layerscape.c >>> index 09056a6..3533a8c 100644 >>> --- a/drivers/pci/dwc/pci-layerscape.c >>> +++ b/drivers/pci/dwc/pci-layerscape.c >>> @@ -107,33 +107,6 @@ static int ls1021_pcie_link_up(struct dw_pcie *pci) >>> return 1; >>> } >>> <cut> > > - Enable write permission in dw_pcie_setup_rc() and remove class > code update from ls_pcie_host_init() This will make it obvious > that fixing dw_pcie_setup_rc() makes ls_pcie_fix_class() obsolete. > > Does this dw_pcie_setup_rc() fix mean we can also get rid of the > device class check in qcom_pcie_rd_own_conf()? Thanks for the CC, I'll manage to test those patches and after that I'll confirm does this fixes device_class register value for qcom driver. regards, Stan