Re: [PATCH] PCI: hisi: remove unused variable driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jul 21, 2017 at 09:26:06AM +0800, Shawn Lin wrote:
> It was never used and also introduce a warning
> 
> drivers/pci/dwc/pcie-hisi.c: In function 'hisi_pcie_probe':
> drivers/pci/dwc/pcie-hisi.c:271:24: warning: variable 'driver' set but
> not used [-Wunused-but-set-variable]
> 
> Cc: Gabriele Paoloni <gabriele.paoloni@xxxxxxxxxx>
> Cc: Zhou Wang <wangzhou1@xxxxxxxxxxxxx>
> Signed-off-by: Shawn Lin <shawn.lin@xxxxxxxxxxxxxx>

Applied to pci/host-hisi for v4.14 with acks from Zhou and Gabriele, thanks!

> ---
> 
>  drivers/pci/dwc/pcie-hisi.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/pci/dwc/pcie-hisi.c b/drivers/pci/dwc/pcie-hisi.c
> index e51acee..6631654 100644
> --- a/drivers/pci/dwc/pcie-hisi.c
> +++ b/drivers/pci/dwc/pcie-hisi.c
> @@ -268,7 +268,6 @@ static int hisi_pcie_probe(struct platform_device *pdev)
>  	struct dw_pcie *pci;
>  	struct hisi_pcie *hisi_pcie;
>  	struct resource *reg;
> -	struct device_driver *driver;
>  	int ret;
>  
>  	hisi_pcie = devm_kzalloc(dev, sizeof(*hisi_pcie), GFP_KERNEL);
> @@ -282,8 +281,6 @@ static int hisi_pcie_probe(struct platform_device *pdev)
>  	pci->dev = dev;
>  	pci->ops = &dw_pcie_ops;
>  
> -	driver = dev->driver;
> -
>  	hisi_pcie->pci = pci;
>  
>  	hisi_pcie->soc_ops = of_device_get_match_data(dev);
> -- 
> 1.9.1
> 
> 



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux