Hi, The patch looks correct. On 07/16/2017 09:39 AM, Bjorn Andersson wrote: > When the init op fails it will restore the state of the resources, so we > should not disable them one more time when this happens. > > Signed-off-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx> > --- > drivers/pci/dwc/pcie-qcom.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Stanimir Varbanov <svarbanov@xxxxxxxxxx> > > diff --git a/drivers/pci/dwc/pcie-qcom.c b/drivers/pci/dwc/pcie-qcom.c > index d15657dc3990..7b703741a3fd 100644 > --- a/drivers/pci/dwc/pcie-qcom.c > +++ b/drivers/pci/dwc/pcie-qcom.c > @@ -901,7 +901,7 @@ static int qcom_pcie_host_init(struct pcie_port *pp) > > ret = pcie->ops->init(pcie); > if (ret) > - goto err_deinit; > + return ret; > > ret = phy_power_on(pcie->phy); > if (ret) >