On Sun, Jul 16, 2017 at 07:56:38PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@xxxxxxx>
>
> The reset GPIO can be connected to a I2C or SPI IO expander, which
> may sleep, so it is safer to use the gpiod_set_value_cansleep()
> variant instead.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@xxxxxxx>
Any opinion, Stanimir?
> ---
> drivers/pci/dwc/pcie-qcom.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/dwc/pcie-qcom.c b/drivers/pci/dwc/pcie-qcom.c
> index 68c5f2a..8359de0 100644
> --- a/drivers/pci/dwc/pcie-qcom.c
> +++ b/drivers/pci/dwc/pcie-qcom.c
> @@ -141,13 +141,13 @@ struct qcom_pcie {
>
> static void qcom_ep_reset_assert(struct qcom_pcie *pcie)
> {
> - gpiod_set_value(pcie->reset, 1);
> + gpiod_set_value_cansleep(pcie->reset, 1);
> usleep_range(PERST_DELAY_US, PERST_DELAY_US + 500);
> }
>
> static void qcom_ep_reset_deassert(struct qcom_pcie *pcie)
> {
> - gpiod_set_value(pcie->reset, 0);
> + gpiod_set_value_cansleep(pcie->reset, 0);
> usleep_range(PERST_DELAY_US, PERST_DELAY_US + 500);
> }
>
> --
> 2.7.4
>
