On Tue, Jul 18, 2017 at 05:12:25PM +0300, Aleksandr Bezzubikov wrote:
> An MSI-based SHPC built in PCI bridges can configure hotplugged devices
> only if they notify the bridge with MSI.
> But they can't trigger interrupt without the bridge being busmaster,
> that's why it should be enabled.
>
> Signed-off-by: Aleksandr Bezzubikov <zuban32s@xxxxxxxxx>
> Reviewed-by: Marcel Apfelbaum <marcel@xxxxxxxxxx>
Given there's pci_enable_msi above, not enabling bus master
seems like a very strange thing to do.
Acked-by: Michael S. Tsirkin <mst@xxxxxxxxxx>
This also looks like a good candidate for stable.
> ---
> drivers/pci/hotplug/shpchp_hpc.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/pci/hotplug/shpchp_hpc.c b/drivers/pci/hotplug/shpchp_hpc.c
> index de0ea47..e5824c7 100644
> --- a/drivers/pci/hotplug/shpchp_hpc.c
> +++ b/drivers/pci/hotplug/shpchp_hpc.c
> @@ -1062,6 +1062,8 @@ int shpc_init(struct controller *ctrl, struct pci_dev *pdev)
> if (rc) {
> ctrl_info(ctrl, "Can't get msi for the hotplug controller\n");
> ctrl_info(ctrl, "Use INTx for the hotplug controller\n");
> + } else {
> + pci_set_master(pdev);
> }
>
> rc = request_irq(ctrl->pci_dev->irq, shpc_isr, IRQF_SHARED,
