On Mon, Jul 31, 2017 at 10:53 PM, Bjorn Helgaas <helgaas@xxxxxxxxxx> wrote: > On Fri, Jul 21, 2017 at 02:38:08PM +0200, Rafael J. Wysocki wrote: >> From: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx> >> >> PCI bridges only have a reason to generate wakeup signals on behalf >> of devices below them, so avoid preparing bridges for wakeup directly >> in pci_enable_wake(). >> >> Also drop the pci_has_subordinate() check from pci_pm_default_resume() >> as this will be done by pci_enable_wake() itself now. >> >> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx> > > Acked-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx> Thanks! >> --- >> drivers/pci/pci-driver.c | 4 +--- >> drivers/pci/pci.c | 7 +++++++ >> 2 files changed, 8 insertions(+), 3 deletions(-) >> >> Index: linux-pm/drivers/pci/pci.c >> =================================================================== >> --- linux-pm.orig/drivers/pci/pci.c >> +++ linux-pm/drivers/pci/pci.c >> @@ -1909,6 +1909,13 @@ int pci_enable_wake(struct pci_dev *dev, >> { >> int ret = 0; >> >> + /* >> + * Bridges can only signal wakeup on behalf of subordinate devices, >> + * but that is set up elsewhere, so skip them. > > A specific pointer to this "elsewhere" would be useful here. OK