Hi Christoph, Looking deep into to this, i think there is no need to use phy_to_virts since pdev->rom is already a physical address. That's what pci_platform_rom should return, right?! I'll probably send a new patch removing the usage of phys_to_virt. Regards, C.Palminha On 20-07-2017 09:07, Christoph Hellwig wrote: > On Wed, Jul 19, 2017 at 01:05:35PM +0100, Carlos Palminha wrote: >> Add missing __iomem annotation to fix sparse warning: >> - incorrect type in return expression (different address spaces) > > How is this going to shut up sparse without a __force? > > And once you add the __force please also add a comment explaining > why it's safe. >
