On Thu, Jul 20, 2017 at 03:56:54PM -0600, Scott Bauer wrote: > On Tue, Jul 25, 2017 at 08:36:10PM -0600, Jon Derrick wrote: > > > > I think we'll need to do more than free the irq handlers because if an > > interrupt occurs after that, I think it'll get kicked to handle_bad_irq. > > I think we just need to add pci_disable_device after save and > > pcim_enable_device after restore. > > I orignally had this in the patch I was testing on SLES and took it out when > it seemingly didn't make a difference. I didnt test yanking a drive or anything > behind the domain while it was suspended, so I wouldn't have hit your scenario. > > I'll add it back in. Also, I think I need to CC stable on this one too since > this is missing all the way since the original inception of this driver. I think your patch should be okay as-is. After freeing VMD's IRQs, the kernel will automatically clear the MSI-x control bit to disable it from firing.
